Skip to content

HYDI-32: Phase 1: Unit tests for pure logic (ADF, prompt, model, columns, deps)#26

Draft
kasperwelner wants to merge 1 commit intomainfrom
agent/HYDI-32
Draft

HYDI-32: Phase 1: Unit tests for pure logic (ADF, prompt, model, columns, deps)#26
kasperwelner wants to merge 1 commit intomainfrom
agent/HYDI-32

Conversation

@kasperwelner
Copy link
Copy Markdown
Contributor

@kasperwelner kasperwelner commented May 7, 2026

Implements HYDI-32

Changes

  • Added Phase 1 unit tests for pure logic modules:
    • src/orchestration/spawner.test.ts (ADF extraction, prompt building, model resolution including { value: "..." }, plus mocked spawn flow)
    • src/orchestration/dependency-resolver.test.ts (eligibility and cycle detection branches, including fetch-error swallow behavior lock with TODO)
    • src/jira/columns.test.ts (expanded name/mapping branch coverage)
    • src/orchestration/monitor.test.ts (helper-only parsing/extraction tests)
    • src/webhook/jira-helpers.test.ts (priority mapping helper coverage)
  • Exported helper functions required for direct unit testing:
    • adfToText, buildPrompt, resolveModel in src/orchestration/spawner.ts
    • parseGithubPullRequestUrl, extractPrUrl in src/orchestration/monitor.ts
    • priorityNameToNumber via src/webhook/jira.ts (re-exported from src/orchestration/ticket-sync.ts)
  • Fixed model field resolution in resolveModel to support Jira select-style values shaped as { value: "..." }.
  • Updated docs/worker-agents.md to document object-shaped Jira model-field support.

Validation

  • npm test
  • npm run test:coverage
  • npm run typecheck
  • Required target coverage (from coverage-final.json):
    • src/orchestration/spawner.ts: statements 100%, branches 87.8%, functions 100%
    • src/jira/columns.ts: statements 100%, branches 100%, functions 100%
    • src/orchestration/dependency-resolver.ts: statements 100%, branches 94.12%, functions 100%

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://app.warp.dev/conversation/c47ed889-514f-4b71-8ced-043823a7666d
Run: https://oz.warp.dev/runs/019e0400-7710-766a-8e54-880667fb4a75
This PR was generated with Oz.

…mns, deps)

Co-Authored-By: Oz <oz-agent@warp.dev>
@hyperbolic-coolify
Copy link
Copy Markdown

hyperbolic-coolify Bot commented May 7, 2026

The preview deployment for hyper-dispatch is ready. 🟢

Open Preview | Open Build Logs | Open Application Logs

Last updated at: 2026-05-07 20:00:25 CET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant