Skip to content

HYDI-35: Add Jira validator and config route phase-4 tests#32

Draft
kasperwelner wants to merge 3 commits intomainfrom
agent/HYDI-35
Draft

HYDI-35: Add Jira validator and config route phase-4 tests#32
kasperwelner wants to merge 3 commits intomainfrom
agent/HYDI-35

Conversation

@kasperwelner
Copy link
Copy Markdown
Contributor

@kasperwelner kasperwelner commented May 11, 2026

Implements HYDI-35

Changes

  • Added comprehensive Jira validator tests in src/validator/jira.test.ts for board columns, workflow statuses, custom field checks (including skip mode), network/status failures, custom mapping normalization, and valid = checks.every(c => c.passed) behavior.
  • Expanded src/routes/config.test.ts for critical config route paths: create validation and normalization, update token preservation/updates, skills discovery success/error paths, and /validate mapping passthrough.
  • Hardened src/routes/config.ts behavior to match tested contracts:
    • POST /config now returns 400 and re-renders form content when required fields are missing.
    • POST /config and POST /config/:projectKey normalize Jira column overrides via resolveJiraColumnMappings.
    • POST /config/skills is registered before /:projectKey POST route to avoid dynamic-route shadowing.
    • MCP JSON parse errors infer line numbers when parser position details are unavailable.
  • Updated docs/api.md to reflect config route behavior and method/error semantics.

Validation

  • npm test -- src/validator/jira.test.ts src/routes/config.test.ts
  • npm test
  • npm run test:coverage
  • npm run typecheck
  • Coverage:
    • src/validator/jira.ts: 86.48% statements
    • src/routes/config.ts: 71.8% statements

Co-Authored-By: Oz oz-agent@warp.dev

Conversation: https://app.warp.dev/conversation/1e098a22-b8ce-43ea-bbd8-916bbe1d025a
Run: https://oz.warp.dev/runs/019e174d-e2fd-7e10-991a-06d599c726f3
This PR was generated with Oz.

@hyperbolic-coolify
Copy link
Copy Markdown

hyperbolic-coolify Bot commented May 11, 2026

The preview deployment for hyper-dispatch is ready. 🟢

Open Preview | Open Build Logs | Open Application Logs

Last updated at: 2026-05-11 14:04:08 CET

kasperwelner and others added 2 commits May 11, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant