Fix/feedback cr self service into Development#121
Merged
noelsaw1 merged 7 commits intodevelopmentfrom Mar 24, 2026
Merged
Conversation
- php-shell-exec-functions: add \b word boundary to exec-call pattern to prevent curl_exec() being flagged as shell execution (8 CRITICAL FPs) - php-dynamic-include: exclude lines containing 'wp-load' from dynamic include detection; WP bootstrap finder pattern (static array -> wp-load.php) is not a user-controlled include vulnerability (2 CRITICAL FPs)
spo-002 CURLOPT_POST FPs (~30 findings): - Root cause: inline bash grep uses double-quoted \FEEDBACK-CR-SELF-SERVICE.md which expands the $_ bash special variable (last command arg), corrupting the ERE pattern - JSON pattern itself is correct; bug is in check-performance.sh ~L3723 - Fix: single-quote the inline grep pattern string unsanitized-superglobal-read sanitized-reads FPs (~20 findings): - Root cause: simple pattern runner (check-performance.sh ~L5970) never applies exclude_patterns from the JSON definition - Same-line sanitize_text_field/isset wrapping is not filtered out - Fix: pipe cached_grep output through grep -v for each exclude_pattern
- single-quote inline spo-002 grep to stop bash $_ expansion from corrupting the superglobal regex at runtime - honor JSON exclude_patterns and exclude_files in the simple pattern runner before adding findings - document measured impact from verification scan against creditconnection2-self-service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue
Fixes #(issue number)
Changes Made
Testing
dist/tests/run-fixture-tests.sh- All tests passdist/tests/fixtures/clean-code.phpChecklist
CLA Signature
For first-time contributors: Please comment below with:
This is a one-time requirement. Once signed, you can contribute to all future PRs without re-signing.
Questions about the CLA? See CLA.md or email cla@hypercart.com
Additional Notes