Add notification system infrastructure (issue #89, Phase 1)#91
Merged
Conversation
barreiro
approved these changes
May 15, 2026
| @Path("methods") | ||
| @PermitAll | ||
| @Operation(description = "List available notification methods") | ||
| public List<NotificationMethod> getAvailableMethods() { |
Contributor
There was a problem hiding this comment.
not needed. NotificationMethod is an enum, all values are present in the open api spec aready
Introduce the notification SPI, entities, service, REST endpoints, and CLI commands for configuring and dispatching change detection notifications. Core components: - NotificationPlugin SPI with CDI auto-discovery for plugin implementations - NotificationMethod enum (WEBHOOK, EMAIL, SLACK, GITHUB_ISSUE) - NotificationConfig entity with per-folder config, secrets (@JsonIgnore), and user-defined message template with placeholders - NotificationLog entity for notification history and debugging - NotificationService observes ChangeDetectedEvent and dispatches to configured plugins, logging each attempt Event changes: - ChangeDetectedEvent now carries folderId (for config lookup) and dispatch flag (false suppresses notifications for recalculate/bulk import) - WorkService.execute() resolves folderId from source values REST API: - POST/GET/PUT/DELETE /api/notification/config for CRUD - GET /api/notification/log for notification history - GET /api/notification/methods for available plugin methods CLI commands: - add notification <method> to <folder> <data> [--secrets] [--template] - list notifications [folder] - remove notification <id> No plugin implementations are included — those come in subsequent phases. Design doc added at docs/design/notification-system.md.
barreiro
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the notification SPI, entities, service, REST endpoints, and CLI commands for configuring and dispatching change detection notifications.
Core components:
Event changes:
REST API:
CLI commands:
No plugin implementations are included — those come in subsequent phases. Design doc added at docs/design/notification-system.md.