Skip to content

Fixed #26 -- Support CDP spec r970581#27

Closed
HMaker wants to merge 3 commits intoHyperionGray:masterfrom
HMaker:cdp-r970581
Closed

Fixed #26 -- Support CDP spec r970581#27
HMaker wants to merge 3 commits intoHyperionGray:masterfrom
HMaker:cdp-r970581

Conversation

@HMaker
Copy link

@HMaker HMaker commented Mar 1, 2022

Fixes #26

@HMaker
Copy link
Author

HMaker commented Mar 1, 2022

@mehaase can you review this?

@HMaker
Copy link
Author

HMaker commented Mar 1, 2022

I made the generated code use relative imports so it can be self-contained and exported to other python projects.

@mehaase
Copy link
Contributor

mehaase commented Mar 2, 2022

Hi @HMaker unfortunately I don’t work for this company anymore and I can’t merge PRs. I took a glance at the PR and it looks nice.

@HMaker HMaker closed this Mar 3, 2022
@HMaker HMaker deleted the cdp-r970581 branch March 3, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generator makes non-default argument follows default argument for CDP r970581

2 participants