Skip to content

Conversation

@g0nz4I0
Copy link
Member

@g0nz4I0 g0nz4I0 commented Dec 28, 2023

Bunch of changes review carefully:

RTC:

  • Created a global static entity to allow direct access and usage as a variable within a Packet
  • Moved to a separate file (minor stuff)

Boundary:

  • Sending now uses standard packets, containing (roughly):
    id(TBD) | format_id | boundary_type_id | name_len | name |
    < Boundary metrics> |     < Boundary metrics> |     < Boundary metrics> |
   RTC data |    RTC data |    RTC data |    RTC data |    RTC data |
   RTC data |    RTC data |    RTC data |    RTC data |    RTC data |

Protection Manager:

  • Added an initialize() method that sets the name of all the boundaries registered, since it does not make any sense to have to do it every time you want to send it

Discarded the notification class, still have to revisit the functionality,
Unified the TIME_ACCUMULATION specialization instead of having the same one for doubles and floats

@g0nz4I0 g0nz4I0 requested a review from StefanCostea December 29, 2023 22:59
@ricardochust
Copy link
Contributor

ricardochust commented Jan 4, 2024

Remember to add a bit of doxygen documentation when its all working

Copy link
Member

@StefanCostea StefanCostea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g0nz4I0 g0nz4I0 merged commit da595da into development Jan 8, 2024
@jmaralo jmaralo deleted the feature/protections_refactor branch September 10, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants