[FW-73] Actualizar modelo PIN de la HALAL Mock #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaralo
approved these changes
Oct 21, 2024
Member
jmaralo
left a comment
jmaralo
left a comment
There was a problem hiding this comment.
LGTM (Looks Good To Me), there are still a few references to the types the HAL uses (namely GPIO_TypeDef) but that shouldn't be an issue.
Member
|
Also I had to change the base branch, I just sent a message to the firmware channel on Slack, make sure to read it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all HAL calls and HAL_GPIO_Init struct configurations, void Pin::start() is now empty and does nothing at the moment.