Skip to content

Conversation

@Cantonplas
Copy link
Contributor

DigitalOutputService for Halal_Mock

@Cantonplas Cantonplas changed the base branch from main to feature/add_mock_scaffolding October 21, 2024 13:33
Copy link
Member

@jmaralo jmaralo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you tried to use bitwise operators, but in this case you have a great enum called PinState that already encodes the two possible states and is easier to read than using bitwise logic. You can use the already existing PinState enum, if it doesn't have a clear value assinged to high and low you can do it like this in the enum definition:

enum class PinState : uint8_t {
    HIGH = 1,
    LOW = 0,
},

As I said in the other comments, I don't know the exact variant name, but you get the idea

@Cantonplas Cantonplas requested a review from jmaralo October 21, 2024 13:57
Copy link
Member

@jmaralo jmaralo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Looks Good To Me), we'll have to make some small changes in the future to integrate with the latest changes Jorge is working on, but will work for now.

@Cantonplas Cantonplas changed the title Add sources and constants to define the amount of memory needed DigitalOutputService for Halal_Mock Oct 21, 2024
@jmaralo jmaralo merged commit acd52f5 into feature/add_mock_scaffolding Oct 22, 2024
@jmaralo jmaralo deleted the feature_FW-52_DigitalOutputService branch October 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants