Fix/make simulator compile #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hernet.cpp in the simulator. As we won't use ethernet I have deleted everything related with confgure ethernet
…o transform bytes into IP_ADDRESS
…loopUPV-H8/ST-LIB into fix/make-simulator-compile
jmaralo
approved these changes
Oct 31, 2024
Member
jmaralo
left a comment
jmaralo
left a comment
There was a problem hiding this comment.
TLDR (like literally what I did), nice PR tho
Member
Author
Review ADC carefully please |
g0nz4I0
commented
Nov 4, 2024
g0nz4I0
commented
Nov 4, 2024
g0nz4I0
commented
Nov 4, 2024
g0nz4I0
commented
Nov 4, 2024
Member
Author
g0nz4I0
left a comment
g0nz4I0
left a comment
There was a problem hiding this comment.
I cannot approve it because I'm the author, but it looks fine, some stuff I have doubts, but it is a great step in the right direction
…H8/ST-LIB into fix/make-simulator-compile
jorgesg82
approved these changes
Nov 7, 2024
added 6 commits
November 7, 2024 18:58
jdmarmen
force-pushed
the
fix/make-simulator-compile
branch
from
ae18fb8 to
e2fc18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several compilation errors, and some refactors to ADC because the maps needed some comparison operators so got rid of them and added hacky patch, to assing from id to pin.
Also refactored EmulatedPin class to make intent clearer and not the mess that it was
Removed:
Some changes are required on EXTI model to move forward with compilation
The other issue is Ethernet that @oganigl is working on.