[FW-95]TestEncoder #457
Merged
[FW-95]TestEncoder #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikubimu
changed the title
g0nz4I0
reviewed
Nov 17, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
g0nz4I0
requested changes
Nov 17, 2024
Member
g0nz4I0
left a comment
g0nz4I0
left a comment
There was a problem hiding this comment.
I understand the logic behind returning 0 if it fails, but there is no strict need, the ErrorHandler will trigger.
You can check it was triggered by checking a variable static double ErrorHandler::error_triggered;
g0nz4I0
approved these changes
Nov 17, 2024
jdmarmen
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed test Inscribe, turn_on, turn_off, get_direccion, get counter and reset.
Inscribe on Encoder.cpp has been modifiied to return a id != 0