Merged
Conversation
Member
|
Most probably the non DMA variant was removed due to its blocking nature. This addition is fine, however I would recomend refactoring the BMS-LIB to use the non blocking variant |
jmaralo
approved these changes
Mar 3, 2025
Contributor
Author
Yes, the idea is to remake the BMS-LIB this year. I want even to try to make it STLIB-independent. But, at the moment, we should use the old one, and it doesn't use DMA, so I need this. Actually, It isn't necessary to merge that on master, I just need this branch so I can point to this from BMS-LIB |
Ikubimu
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug has been detected when trying to use the old BMS-LIB. It was working with the old ST-LIB but it ins't working with the new one. Comparing both, It has been detected that two functions were removed: receive and transmit_and_receive without DMA. It has been tried to add them again and BMS-LIB is working.
@Ikubimu wasn't able neither to use SPI, apart of SPIOrder (which use HAL directly), so maybe with this change now he is able to use it.
Is important that @g0nz4I0 or @jmaralo review this, as I guess this code was removed for some reason that the new ones can't figure out, so please, give us your experienced opinion