Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the watchdog functionality by integrating refresh, start, and reset flag capabilities across multiple modules.
- Added watchdog refresh call in the STLIB update routine.
- Updated Watchdog initialization, timing calculation, and reset flag check across HALAL and Watchdog modules.
- Adjusted header comments and minor formatting in related files.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Src/ST-LIB.cpp | Calls Watchdog::refresh() in the update loop. |
| Src/HALAL/Services/Watchdog/Watchdog.cpp | Sets default watchdog timing and flag. |
| Src/HALAL/HALAL.cpp | Integrates Watchdog start and reset flag check. |
| Inc/ST-LIB.hpp | Minor cleanup of included headers. |
| Inc/HALAL/Services/Watchdog/Watchdog.hpp | Updates Watchdog interface and comment wording. |
Ikubimu
previously approved these changes
Apr 9, 2025
Contributor
Ikubimu
left a comment
Ikubimu
left a comment
There was a problem hiding this comment.
WOW watchdog watch a dog or wathever
copilot leads Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
copilot leads II Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for the future checking the watchdog, please be careful with the dog Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jdmarmen
approved these changes
Apr 9, 2025
Ikubimu
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watchdog fixed