Refactored compile infrastructure#531
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the compile infrastructure to support conditional Ethernet compilation via STLIB_ETH preprocessor define. It introduces a Docker-based CI/CD pipeline, removes simulator/mock code, consolidates HAL initialization, and restructures CMake to filter sources based on Ethernet support.
- Adds conditional Ethernet compilation with
STLIB_ETHguard - Implements Docker-based build toolchain with STM32CubeCLT 1.16.0
- Removes all HALALMock files and SIM_ON support
- Refactors CMake to filter source files by Ethernet dependency using regex patterns
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Major refactor: adds conditional source filtering for ETH/NO_ETH variants, updates C/C++ standards (C++23, C17) |
| ci/Dockerfile | New Docker image for build toolchain with STM32CubeCLT, git, cmake, ninja |
| .github/workflows/*.yml | Updates CI to use new Docker image and init submodules explicitly |
| tools/init-submodules.sh | Improves portability by computing script directory instead of using git rev-parse |
| Src/HALAL/HALAL.cpp | Splits start() into ETH/non-ETH variants, extracts common_start() helper |
| Src/ST-LIB.cpp | Adds conditional start() overloads based on STLIB_ETH |
| Inc/HALAL/HALAL.hpp | Removes SIM_ON conditionals, adds STLIB_ETH guards for Ethernet headers |
| Inc/HALALMock/* | All mock/simulator files deleted |
| Src/ST-LIB_LOW/StateMachine/*.cpp | Comments out StateOrder functionality (ETH-dependent) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@jorgesg82 I've opened a new pull request, #532, to work on those changes. Once the pull request is ready, I'll request review from you. |
) * Initial plan * Replace commented-out StateOrder code with #ifdef STLIB_ETH preprocessor guards Co-authored-by: jorgesg82 <125664643+jorgesg82@users.noreply.github.com> * Address feedback on commented-out StateOrder code Co-authored-by: jorgesg82 <125664643+jorgesg82@users.noreply.github.com> * Remove CodeQL build artifacts and update .gitignore Co-authored-by: jorgesg82 <125664643+jorgesg82@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jorgesg82 <125664643+jorgesg82@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.