fix(SPI): Make it compile in every compiler#579
Merged
jorgesg82 merged 1 commit intodevelopmentfrom Feb 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a compiler compatibility issue by replacing designated initializers with member-by-member assignment in the SPI domain initialization code. Designated initializers (using .field = value syntax) introduced in C++20 have limitations and may not be fully supported by all C++ compilers, particularly older versions of arm-none-eabi-g++ used for cross-compilation to embedded ARM targets.
Changes:
- Replaced designated initializer syntax with explicit member-by-member assignment for the
Entrystruct inSPIDomain::Device::inscribe() - This ensures the code compiles successfully across different compiler toolchains
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just what the title says