Skip to content

Backend/transport #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Humanoidear merged 7 commits into from
Nov 26, 2025
Merged

Backend/transport #389

Humanoidear merged 7 commits into from
Nov 26, 2025

Conversation

@vasyl-ks
Copy link
Contributor

@vasyl-ks vasyl-ks commented Nov 26, 2025

Summary

Transport refactor for clearer TCP connection handling and safer error notifications, updated transport tests for stability, and a logger start callback that informs the frontend.

Implementation

  • Transport refactor (backend/transport): split handleTCPConn into focused helpers (configure TCP options, map remote IP to target, guard against duplicate connections, register/unregister, read loop). Guard errChan and TFTP error sends to avoid nil/duplicate notifications.
  • Transport tests (backend/transport/tests): switch to zerolog.Nop() to prevent goroutine panics from test loggers, wire encoder/decoder for packet id 100, add invalid-input/removal coverage, and wait on connection updates before asserting.
  • Logger callback (backend/logger): add an on-start hook to the logger and notify the frontend when logging begins.

@vasyl-ks
refactor(backend, transport): split handleTCPConn into focused helpers
4c46ff9 
- Extract TCP configuration into configureTCPConn
- Extract IP-to-target lookup into resolveTarget
- Extract single-connection check into checkIfActiveConnection
- Extract connection registration into addConnection
- Extract receive loop into tcpReceiveLoop
@vasyl-ks
refactor(backend, transport): polish handleTCPConn helpers
1ba5360
@vasyl-ks
fix(backend, transport, test): wire encoder for packet id 100 and wai…
b80a652 
…t for transport connection update in tests
@vasyl-ks
refactor(backend, transport): rename TCP connection helpers for clarity
f7ace86
@vasyl-ks
feat(backend, logger): add start hook and notify frontend on start
6248356
@vasyl-ks
fix(backend, transport): guard errChan sends to avoid nil error notif…
b456187 
…ications
@vasyl-ks
fix(backend, transport, test): stop using testing logger in transport
db40d44 
- use zerolog.Nop() in createTestTransport
- avoid panic when background goroutines log after tests
@Humanoidear Humanoidear merged commit 3d3fe29 into develop Nov 26, 2025
3 checks passed
@Humanoidear Humanoidear deleted the backend/transport branch November 26, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Humanoidear Humanoidear Humanoidear approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vasyl-ks @Humanoidear