[FW-296] Added the code needed to execute the simulator tests with GitHub actions #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 26, 2025 15:10
…on 0 argument when a test fails
g0nz4I0
requested changes
Mar 3, 2025
Member
g0nz4I0
left a comment
g0nz4I0
left a comment
There was a problem hiding this comment.
Why did you change the ALLOWED_SLACK?, everything else looks good.
Contributor
Author
Test wasn't passing with lower slacks, it literally works from 100 onwards. I guess it's due to the issues with low time measurwments that Juan has mentioned a bunch of times. |
Member
|
The thing with the SLACK is probably due to github action runners being low on resources, maybe we should execute the simulation with a slower clock both in python and c++ |
jmaralo
previously approved these changes
Mar 3, 2025
jmaralo
previously approved these changes
Mar 6, 2025
g0nz4I0
pushed a commit
that referenced
this pull request
Jan 13, 2026
…-actions [FW-296] Added the code needed to execute the simulator tests with GitHub actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.