Make command hypernode:performance compatibly with n98-magerun2#50
Merged
vdloo merged 4 commits intoHypernode:masterfrom Aug 23, 2017
tdgroot:master-hypernode-performance-magerun2
Merged
Make command hypernode:performance compatibly with n98-magerun2#50vdloo merged 4 commits intoHypernode:masterfrom tdgroot:master-hypernode-performance-magerun2
vdloo merged 4 commits intoHypernode:masterfrom
tdgroot:master-hypernode-performance-magerun2
Conversation
Collaborator
Author
|
Oh and PHP 5.5 builds are crashing because of hard minimum required PHP version 7.1 in latest version of |
Member
|
👍 👍 👍 great addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was possible by initializing Magento only when it's necessary. Also got rid of dependency on
\Varien_Simplexml_Elementby using\SimpleXMLElementinstead.Additionally, I added some information to the README as well on how to install the addons for n98-magerun2 as well(it's quite easy).
It's a rough change, but I think this is a step into the right direction. Please let me know if there's something that needs to be changed.