Skip to content

feat: migrating from tsup to tsdown#130

Merged
jaredwray merged 3 commits intomainfrom
feat-migrating-from-tsup-to-tsdown
Apr 13, 2026
Merged

feat: migrating from tsup to tsdown#130
jaredwray merged 3 commits intomainfrom
feat-migrating-from-tsup-to-tsdown

Conversation

@jaredwray
Copy link
Copy Markdown
Contributor

@jaredwray jaredwray commented Apr 13, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat: migrating from tsup to tsdown

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6e279c5) to head (cb104fc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          477       477           
  Branches        95        95           
=========================================
  Hits           477       477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project from tsup to tsdown for building, updates package.json to support modern export maps, and enforces stricter TypeScript rules including isolatedDeclarations. The review identifies an invalid TypeScript version (^6.0.2) in the dependencies and suggests re-enabling the --clean flag in build scripts to prevent the inclusion of stale artifacts in the distribution folder.

Comment thread package.json
Comment thread package.json
Comment thread package.json Outdated
@jaredwray jaredwray merged commit cbb88e7 into main Apr 13, 2026
9 checks passed
@jaredwray jaredwray deleted the feat-migrating-from-tsup-to-tsdown branch April 13, 2026 10:02
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99a158061b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
}
},
"types": "dist/index.d.ts",
"types": "dist/index.d.mts",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point top-level types at CJS-compatible declarations

Changing types to dist/index.d.mts makes CommonJS TypeScript consumers that still use moduleResolution: "node"/"node10" resolve ESM declarations instead of the CJS branch, because those resolvers ignore conditional exports typing and read only the top-level types field. In that setup, import = require('@hyphen/sdk') and similar CJS typing patterns no longer align with the runtime require entry even though exports.require.types is present, so this should point to a CJS-compatible declaration (or a compatibility .d.ts shim) to avoid a regression for legacy CJS TS projects.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant