Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 477 477
Branches 95 95
=========================================
Hits 477 477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request transitions the project from tsup to tsdown for building, updates package.json to support modern export maps, and enforces stricter TypeScript rules including isolatedDeclarations. The review identifies an invalid TypeScript version (^6.0.2) in the dependencies and suggests re-enabling the --clean flag in build scripts to prevent the inclusion of stale artifacts in the distribution folder.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99a158061b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }, | ||
| "types": "dist/index.d.ts", | ||
| "types": "dist/index.d.mts", |
There was a problem hiding this comment.
Point top-level types at CJS-compatible declarations
Changing types to dist/index.d.mts makes CommonJS TypeScript consumers that still use moduleResolution: "node"/"node10" resolve ESM declarations instead of the CJS branch, because those resolvers ignore conditional exports typing and read only the top-level types field. In that setup, import = require('@hyphen/sdk') and similar CJS typing patterns no longer align with the runtime require entry even though exports.require.types is present, so this should point to a CJS-compatible declaration (or a compatibility .d.ts shim) to avoid a regression for legacy CJS TS projects.
Useful? React with 👍 / 👎.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat: migrating from tsup to tsdown