checking Lambda function into version control#133
Merged
SupahNickie merged 6 commits intoIABTechLab:masterfrom Jun 26, 2018
Merged
checking Lambda function into version control#133SupahNickie merged 6 commits intoIABTechLab:masterfrom
SupahNickie merged 6 commits intoIABTechLab:masterfrom
Conversation
samtingleff
reviewed
Jun 26, 2018
| headers: { | ||
| version: [{ | ||
| key: 'Version', | ||
| value: '13' |
Contributor
There was a problem hiding this comment.
Is this Version header useful to keep around?
Contributor
Author
There was a problem hiding this comment.
I'm not entirely certain; would it just go to $LATEST if it's not there?
Contributor
Author
There was a problem hiding this comment.
I'm removing it; seems like it wouldn't really net us anything and would be a nightmare to keep updating in two places if we did make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #33
There is a versioning system on AWS, but it would good for documentation's sake to keep it here as well.