Skip to content

Conversation

@ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Aug 17, 2023

Closes #

Description Of Changes

The clever (not so much apparently) Version type I created is causing issues with database insertion over in Fides ([PR}())

This uses the version during validation but otherwise treats it as a string. This will be released immediately as Fideslang version 2.0.1

Code Changes

  • add version validation while storing as strings
  • add new tests to validate empty values on instantiation

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@ThomasLaPiana ThomasLaPiana self-assigned this Aug 17, 2023
@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review August 21, 2023 18:25
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍 just a small comment for curiosity's sake, not suggesting you need to make the update here.

@ThomasLaPiana ThomasLaPiana merged commit 3952d06 into main Aug 21, 2023
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-fix-version-issues branch August 21, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants