Base TCF Mapping #167
Merged
Base TCF Mapping #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Purpose mapping file not found. * remove commented out line --------- Co-authored-by: Adam Sachs <adam@ethyca.com>
7 tasks
7 tasks
adamsachs
approved these changes
Sep 14, 2023
Contributor
adamsachs
left a comment
adamsachs
left a comment
There was a problem hiding this comment.
this looks great! love to see this finally getting into main here, it's been a long time coming :)
this may be deserving of a 2.1.0 release? i don't think we're very formal with semantic versioning or anything, but adding in some GVL support seems like a bit of a milestone! 🤷
pattisdr
commented
Sep 14, 2023
… remove new line characters from purpose/special purpose descriptions
pattisdr
commented
Sep 14, 2023
adamsachs
approved these changes
Sep 14, 2023
Contributor
adamsachs
left a comment
adamsachs
left a comment
There was a problem hiding this comment.
most recent changes look good, thanks for the diligence around the feature mapping 👍
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds mappings from GVL to new fideslang Purpose and Feature objects as well as utility functions from converting fideslang data uses to Purposes and vice versa.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md