-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Copy link
Description
Description
When Prebid units are routed through trustedServer, server-side bidders are still left in unit.bids. This causes client-side Prebid to attempt requests for bidders that are no longer available and emit console errors like Trying to make a request for bidder that does not exist: pubmatic.
A related hardening change in creative sanitization also removed iframe creatives, which caused blank creative rendering even when wrapper iframes were present.
Reproduction Steps
- Configure Prebid with
trustedServerrouting and include a server-side bidder (for example,pubmatic) in ad unit bids. - Load a page where the JS prebid shim rewrites routing to client-side + trustedServer paths.
- Observe the browser console and creative output.
Expected Behavior
unit.bidsshould only includetrustedServerplus configured client-side bidders after routing.- No Prebid "bidder does not exist" console errors for routed server-side bidders.
- Iframe creatives should render correctly (including wrapper iframe flow) after sanitization and JS render path processing.
Affected Area
- Integrations (prebid, lockr, permutive, etc.)
- HTML processing / JS injection
Version
- Branch:
fix/client-side-bid-issue
Logs / Evidence
- Console error observed before fix:
Trying to make a request for bidder that does not exist: pubmatic
Scope of Fix Implemented
- Filtered
unit.bidsin JS prebid shim to keep onlytrustedServer+ configured client-side bidders. - Allowed iframe creatives again in server-side sanitizer (
trusted-server-core/src/creative.rs). - Restored required creative iframe sandbox tokens in JS render path.
- Updated tests for routing and creative rendering behavior.
Validation
cargo test --workspacepassesnpx vitest runpasses
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels