Skip to content

Conversation

@sophia-chen-ttd
Copy link
Contributor

@sophia-chen-ttd sophia-chen-ttd commented May 13, 2025

Salts will only be considered for rotation if their refresh_from is equal to the target date. Feature is behind a feature switch, which can be enabled through the admin config file.

Unit test:

  • salts that are old enough to rotate and are refreshing on target date will be considered for rotation
  • salts that not old enough to rotate and are refreshing on the target date are not rotated
  • salts that are old enough to rotate but are not refreshing on target date are not rotated
  • refresh_from dates are updated appropriately

@sophia-chen-ttd sophia-chen-ttd merged commit eb5d42f into main May 13, 2025
4 checks passed
@sophia-chen-ttd sophia-chen-ttd deleted the sch-UID2-5352-salt-rotation-honour-refresh-from branch May 13, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants