Add the ability to delete client-side keypairs #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian-Nara
commented
Jun 10, 2025
|
|
||
| } | ||
|
|
||
| private JsonObject getRequestBody(RoutingContext rc) { |
Contributor
Author
There was a problem hiding this comment.
These two helper methods are to reduce the code duplication of retrieving a specific keypair, which is now done by both update and delete
| }); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Can we add some tests where the user doesn't have the required roles?
mcollins-ttd
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI and output look like:
Asks for confirmation:
