UID2-5482 Use handleWithAudit for auth middleware #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
force-pushed
the
kcc-UID2-5482-audit-logging-in-optout
branch
from
4dabb1c to
38f7d2c
Compare
asloobq
reviewed
Jun 2, 2025
| public static final String OptOutDeleteExpiredProp = "optout_delete_expired"; | ||
| public static final String PartnersConfigPathProp = "partners_config_path"; | ||
| public static final String PartnersMetadataPathProp = "partners_metadata_path"; | ||
| public static final String EnableAuditLoggingProp = "enable_audit_logging"; |
There was a problem hiding this comment.
I think we want the Auditlog to be enabled always for optout. So this config may become redundant later.
cYKatherine
force-pushed
the
kcc-UID2-5482-audit-logging-in-optout
branch
from
e02b247 to
440476a
Compare
cYKatherine
force-pushed
the
kcc-UID2-5482-audit-logging-in-optout
branch
from
440476a to
f632b86
Compare
asloobq
approved these changes
Jun 3, 2025
| final String jwtAudience = jsonConfig.getString(Const.Config.OptOutUrlProp); | ||
| final String jwtIssuer = jsonConfig.getString(Const.Config.CorePublicUrlProp); | ||
| Boolean enforceJwt = jsonConfig.getBoolean(Const.Config.EnforceJwtProp, true); | ||
| Boolean enforceJwt = jsonConfig.getBoolean(Const.Config.EnforceJwtProp, false); |
There was a problem hiding this comment.
is this intentional to keep default value false ?
| Handler<RoutingContext> handler = internalAuth.handleWithAudit(nextHandler); | ||
| handler.handle(routingContext); | ||
| verifyNoInteractions(nextHandler); | ||
| verify(routingContext).fail(401); |
There was a problem hiding this comment.
can you add a positive test case as well ?
asloobq
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.