enable enqueue SQS #233
Merged
enable enqueue SQS #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkxuyang
reviewed
Nov 5, 2025
| } | ||
| }, res -> { | ||
| if (res.failed()) { | ||
| // this.sendInternalServerError(resp, "Failed to queue message: " + res.cause().getMessage()); |
clarkxuyang
reviewed
Nov 5, 2025
| JsonObject responseJson = new JsonObject() | ||
| .put("status", "queued"); | ||
|
|
||
| // resp.setStatusCode(200) |
clarkxuyang
reviewed
Nov 5, 2025
|
|
||
| private void handleReplicate(RoutingContext routingContext) { | ||
|
|
||
| if(this.sqsEnabled){ |
Contributor
There was a problem hiding this comment.
if(this.sqsEnabled && this.sqsClient != null)
clarkxuyang
reviewed
Nov 5, 2025
| String advertisingId = req.getParam(ADVERTISING_ID); | ||
| JsonObject body = routingContext.body().asJsonObject(); | ||
| String traceId = req.getHeader(UID_TRACE_ID); | ||
| String clientIp = body.getString(CLIENT_IP); |
Contributor
There was a problem hiding this comment.
body could be null and cause NPE
String email = body != null ? body.getString(EMAIL) : null;
clarkxuyang
reviewed
Nov 5, 2025
| } | ||
| }); | ||
| } catch (Exception ex) { | ||
| // this.sendInternalServerError(resp, ex.getMessage()); |
clarkxuyang
approved these changes
Nov 5, 2025
…chLab/uid2-optout into ian-UID2-6147-enqueue-requests-sqs merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.