Skip to content

ibg-TTD-786-banners #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ibgrav merged 4 commits into from
Jan 31, 2025
Merged

ibg-TTD-786-banners #807

ibgrav merged 4 commits into from
Jan 31, 2025

Conversation

@ibgrav
Copy link
Collaborator

@ibgrav ibgrav commented Jan 27, 2025 •
edited
Loading

Changes

  • Add new banner markdown header attributes to control the page banner styles
    • banner_icon: NAME_OF_ICON
    • banner_text_color: '#somecolor'
    • banner_text_color_dark: '#somecolor'
    • banner_background_color: '#somecolor'
    • banner_background_color_dark: '#somecolor'
  • Update banner styles to accept new attribute styles
  • Added new banner icons and applied to corresponding banners

@ibgrav ibgrav requested a review from genwhittTTD January 27, 2025 16:58
genwhittTTD
genwhittTTD approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@genwhittTTD genwhittTTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. See my comment on Slack... for colors, would be great to be able to have which text for banner_title and banner_description. Is it possible? But this is all great.

@ibgrav ibgrav requested a review from genwhittTTD January 29, 2025 23:35
@ibgrav ibgrav merged commit 8cfea17 into main Jan 31, 2025
2 checks passed
@ibgrav ibgrav deleted the ibg-TTD-786-banners branch January 31, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genwhittTTD genwhittTTD Awaiting requested review from genwhittTTD

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibgrav @genwhittTTD