Jpn translation update 871,935 952 #955
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genwhittTTD
reviewed
Dec 2, 2025
| import TabItem from '@theme/TabItem'; | ||
| import Link from '@docusaurus/Link'; | ||
| import SnptIdentityGenerateResponse from '../snippets/_snpt-example-identity-generate-response.mdx'; | ||
| import SnptSnptIdentityGenerateResponse from '../snippets/_snpt-example-identity-generate-response.mdx'; |
Collaborator
There was a problem hiding this comment.
@miyaichi we should keep the naming consistent across the boards. This fix in all instances:
import SnptSnpt > import Snpt
I know it doesn't matter as long as the name on the import statement matches where it's referenced, but still, I'd prefer it be consistent across the boards.
FYI we did this just so that it would be easier to find and identify where snippets are imported and referenced.
genwhittTTD
reviewed
Dec 2, 2025
| For example, a decrypted response to the [POST /token/generate](../endpoints/post-token-generate.md) request for an email address might look like this: | ||
|
|
||
| <SnptIdentityGenerateResponse /> | ||
| <SnptSnptIdentityGenerateResponse /> |
Collaborator
There was a problem hiding this comment.
same as previous comment
genwhittTTD
reviewed
Dec 2, 2025
|
|
||
| import Link from '@docusaurus/Link'; | ||
| import SnptIdentityGenerateResponse from '../snippets/_snpt-example-identity-generate-response.mdx'; | ||
| import SnptSnptIdentityGenerateResponse from '../snippets/_snpt-example-identity-generate-response.mdx'; |
Collaborator
There was a problem hiding this comment.
same comment, all instances.
genwhittTTD
requested changes
Dec 2, 2025
Collaborator
genwhittTTD
left a comment
genwhittTTD
left a comment
There was a problem hiding this comment.
All good except a few snippet names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#871 and #953 to #952 (excluding #938 , #947 , #951) have been reflected in the Japanese documentation.