Feature/add svg textures#8
Conversation
…o feature/add_svg_textures
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e36ccaac6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const trimmed = svgMarkup.trim(); | ||
| if (!trimmed.startsWith('<svg')) return ''; |
There was a problem hiding this comment.
normalizeSvgMarkup rejects any input whose trimmed text does not start with <svg>, so common SVG files that begin with an XML declaration/doctype (for example <?xml ...?><svg ...>) are treated as invalid and cannot be imported through the new SVG workbench/file flow. This blocks a broad class of real-world SVG assets even though they are valid SVG documents.
Useful? React with 👍 / 👎.
| applyTextureTransform(texture, previousTransform); | ||
| mesh.userData.texture = texture; | ||
| mesh.userData.textureEnabled = true; | ||
| delete mesh.userData.textureProcessing; |
There was a problem hiding this comment.
applyTexture now clears mesh.userData.textureProcessing, but the undo action created in the same function only restores map/color/enable flags and never restores the previous processing settings. If a user replaces a processed texture and then undoes, the old texture comes back without its FX metadata, so subsequent editor/export behavior can diverge from the pre-action state.
Useful? React with 👍 / 👎.
1 participant
@codex review and make a summary of all the features in this pr