BugFix: load of signer certificates not possible(network or firewall restrictions) #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load of signer certificates had following issues: - loading of local runtime certificates not possible (e.g. ansible can not reach local aac runtime certificate for checking) - ansible is required to be able to load the certificate for comparison (firewall restrictions can prevent this to work properly) fix: additional parameter "check_remote" introduces. description: parameter "check_remote" controls whether to load remote certificate into ansible for comparison or to simply compare the kdb for existance of the label. For backward compatibility and default behavior (LMI) reasons "check_remote" parameter is set to False by default. Previous commit (IBM-Security@c3b3522) broke customer implementations, where firewall blocked the load of the remote certificates from the ansible server.
svetterIO
changed the title
Closed
Collaborator
|
I believe we can determine if "server" is local or not and avoid the need to pass another parameter for it. Will work on setting that logic up. |
Contributor
Author
|
The functionality itself is handy and shouldn't be restricted to requests on the same machine. Maybe some customer want to check the signer certificates from the remote ansible server and therefor they'll give special permissions to allow such access (firewall rules). I think we should let the user decide which functionality to load signer certificates is preferred. |
1) url encoding was mistakenly deleted. added pack. 2) added some logging output for check_remote and certificate comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load of signer certificates had following issues:
fix: additional parameter "check_remote" introduces.
description: parameter "check_remote" controls whether to load remote certificate into ansible for comparison or to simply compare the kdb for existance of the label. For backward compatibility and default behavior (LMI) reasons "check_remote" parameter is set to False by default.
Previous commit (c3b3522) broke customer implementations, where firewall blocked the load of the remote certificates from the ansible server.