Skip to content

Try to fix issue with actions build fail#101

Closed
JakeRoggenbuck wants to merge 1 commit intoIBM:mainfrom
JakeRoggenbuck:fix-actions
Closed

Try to fix issue with actions build fail#101
JakeRoggenbuck wants to merge 1 commit intoIBM:mainfrom
JakeRoggenbuck:fix-actions

Conversation

@JakeRoggenbuck
Copy link
Copy Markdown

Description of the changes

Currently there is a dependency issue in the GitHub action. This PR is an attempt to address this issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Formal verification
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactorization (non-breaking change which improves code quality)

How to test this PR?

GitHub actions will run automatically

Signed-off-by: Jake Roggenbuck <jakeroggenbuck2@gmail.com>
@orangecms
Copy link
Copy Markdown

orangecms commented May 28, 2025

Hi there, I had a quick look; the setup here relies on Python 2.7.
Python 2 has been deprecared long ago and finally been removed in Ubuntu 24.04, and you're using ubuntu-latest, which no longer has it.

Any chance to migrate to later tooling that no longer depends on it?
Otherwise, a venv would be a solution, requiring some more fiddling.

@orangecms
Copy link
Copy Markdown

orangecms commented May 28, 2025

I don't know if Python 2.7 can just be removed from the install list, have never worked with opam.
Suggesting to upgrade opam here and drop Python 2.7: #103

@orangecms
Copy link
Copy Markdown

figured that opam can just be installed from Ubuntu, see #103 :)

@wojciechozga wojciechozga requested a review from lgaeher May 28, 2025 06:32
@wojciechozga
Copy link
Copy Markdown
Member

Thanks for your PR. We fixed the dependency issue in #104 . We keep building opam from sources to maintain better control over its version. I close this PR since the problem has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants