fix: XML pretty-printing crash for non-ASCII in httpops#123
Merged
barny merged 1 commit intoIBM:masterfrom Mar 2, 2026
Merged
Conversation
Signed-off-by: FIXED-TERM Mariotto Lucio Tiago (ME-EC/ENG2) <fixed-term.Tiago.MariottoLucio@de.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves #121 by improving the robustness of XML handling in the logging functions of
elmclient/httpops.py. The changes ensure that XML parsing errors do not interrupt logging by introducing exception handling and proper encoding management.Improvements to XML logging robustness:
try/exceptblocks around XML parsing and formatting in both_log_requestand_log_responseto prevent failures when encountering malformed XML or encoding issues. [1] [2]encoding='unicode', ensuring consistent output and handling of string/byte inputs. [1] [2]