Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Fix NAMESPACE typo on one of the deployment script#126

Merged
fplk merged 1 commit intomasterfrom
bug-patch
Aug 9, 2018
Merged

Fix NAMESPACE typo on one of the deployment script#126
fplk merged 1 commit intomasterfrom
bug-patch

Conversation

@Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Aug 8, 2018

There is a typo where we need to capitalize NAMESPACE on one of the deployment scripts. The bug only occurs when on a non-default namespace.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Tomcli Tomcli added the bug Something isn't working label Aug 8, 2018
@fplk
Copy link
Contributor

fplk commented Aug 9, 2018

Had tested Namespace before, so while I redeployed after the change to NAMESPACE the environment variables were still set and it worked when it shouldn't have. Thanks for paying attention.

@fplk fplk merged commit 8fbae4f into master Aug 9, 2018
@Tomcli Tomcli deleted the bug-patch branch August 9, 2018 15:58
@Tomcli
Copy link
Contributor Author

Tomcli commented Aug 9, 2018

It was my mistake :) Thanks for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants