Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Use python zipfile instead of unzip shell command #128

Merged
animeshsingh merged 1 commit into from
Aug 15, 2018
Merged

Use python zipfile instead of unzip shell command #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lcm/service/lcm/container_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,12 @@ func constructLearnerContainer(req *service.JobDeploymentRequest, envVars []v1co
//FIXME need to have the learner IDs start from 1 rather than 0
var cmd string
var doCondExitWrite = true
//FIXME we assume all images has python installed to unzip the model.zip
if mountResultsStoreInLearner {
loadModelComand := `
echo "Starting Training $TRAINING_ID"
mkdir -p "$MODEL_DIR" ;
unzip -nq "$RESULT_DIR/_submitted_code/model.zip" -d "$MODEL_DIR"`
python -m zipfile -e $RESULT_DIR/_submitted_code/model.zip $MODEL_DIR `
learnerCommand := `
for i in ${!ALERTMANAGER*} ${!DLAAS*} ${!ETCD*} ${!GRAFANA*} ${!HOSTNAME*} ${!KUBERNETES*} ${!MONGO*} ${!PUSHGATEWAY*}; do unset $i; done;
export LEARNER_ID=$((${DOWNWARD_API_POD_NAME##*-} + 1)) ;
Expand Down