Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Use python zipfile instead of unzip shell command#128

Merged
animeshsingh merged 1 commit intomasterfrom
fix-unzip
Aug 15, 2018
Merged

Use python zipfile instead of unzip shell command#128
animeshsingh merged 1 commit intomasterfrom
fix-unzip

Conversation

@Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Aug 14, 2018

With the DLAAS June release, LCM assumes/requires all the learner images have bash unzip package which some community images such as PyTorch and Caffe don't come with it natively. Thus, as a work around, I changed the unzip command to use python zipfile because all our community images have python installed. However, we may need a better solution in the future where some images only have R or Julia for their runtimes.

@sboagibm what do you think? Thanks in advance.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Tomcli Tomcli added bug Something isn't working Dependencies ffdl-core labels Aug 14, 2018
@Tomcli Tomcli requested a review from sboagibm August 14, 2018 22:28
@animeshsingh
Copy link
Contributor

LGTM

@animeshsingh animeshsingh merged commit f5dcaf6 into master Aug 15, 2018
@Tomcli Tomcli deleted the fix-unzip branch August 15, 2018 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working Dependencies ffdl-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants