This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Use python zipfile instead of unzip shell command#128
Merged
animeshsingh merged 1 commit intomasterfrom Aug 15, 2018
Merged
Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the DLAAS June release, LCM assumes/requires all the learner images have bash unzip package which some community images such as PyTorch and Caffe don't come with it natively. Thus, as a work around, I changed the unzip command to use python
zipfilebecause all our community images have python installed. However, we may need a better solution in the future where some images only have R or Julia for their runtimes.@sboagibm what do you think? Thanks in advance.
Developer's Certificate of Origin 1.1