This repository was archived by the owner on Jan 29, 2026. It is now read-only.
ART notebook not rendered on GitHub#129
Merged
Tomcli merged 2 commits intoIBM:masterfrom Aug 15, 2018
Merged
Conversation
Contributor
Author
Tomcli
suggested changes
Aug 15, 2018
Contributor
Tomcli
left a comment
There was a problem hiding this comment.
Notebook still not rendered on GitHub. Another missing comma somewhere?
Contributor
Author
|
@Tomcli -- nope, all commas there now. It's valid JSON again, but may still be too big for GitHub to render. |
Contributor
|
@ckadner Yeah, it works on my Jupyter Notebook. I'm not sure what's the issue with GitHub since I had seem much bigger notebook get rendered without issue. LGTM. |
Tomcli
approved these changes
Aug 15, 2018
Contributor
Author
|
@Tomcli -- thanks for review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I last updated the notebook ART_model_robustness_check.ipynb I manually truncated the training log output, but I accidentally deleted one comma too many. As a result the notebook could not get rendered on GitHub.
Developer's Certificate of Origin 1.1