Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

ART notebook not rendered on GitHub#129

Merged
Tomcli merged 2 commits intoIBM:masterfrom
ckadner:patch-2
Aug 15, 2018
Merged

ART notebook not rendered on GitHub#129
Tomcli merged 2 commits intoIBM:masterfrom
ckadner:patch-2

Conversation

@ckadner
Copy link
Contributor

@ckadner ckadner commented Aug 15, 2018

When I last updated the notebook ART_model_robustness_check.ipynb I manually truncated the training log output, but I accidentally deleted one comma too many. As a result the notebook could not get rendered on GitHub.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ckadner
Copy link
Contributor Author

ckadner commented Aug 15, 2018

@nilmeier

Copy link
Contributor

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook still not rendered on GitHub. Another missing comma somewhere?

@ckadner
Copy link
Contributor Author

ckadner commented Aug 15, 2018

@Tomcli -- nope, all commas there now. It's valid JSON again, but may still be too big for GitHub to render.

@Tomcli
Copy link
Contributor

Tomcli commented Aug 15, 2018

@ckadner Yeah, it works on my Jupyter Notebook. I'm not sure what's the issue with GitHub since I had seem much bigger notebook get rendered without issue. LGTM.

@Tomcli Tomcli merged commit e358a42 into IBM:master Aug 15, 2018
@ckadner
Copy link
Contributor Author

ckadner commented Aug 15, 2018

@Tomcli -- thanks for review and merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants