This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Assign default edit role to lcm to support kubernetes 1.9 and above#22
Merged
animeshsingh merged 2 commits intoIBM:masterfrom Feb 22, 2018
Tomcli:lcm-rbac
Merged
Assign default edit role to lcm to support kubernetes 1.9 and above#22animeshsingh merged 2 commits intoIBM:masterfrom Tomcli:lcm-rbac
animeshsingh merged 2 commits intoIBM:masterfrom
Tomcli:lcm-rbac
Conversation
Contributor
animeshsingh
left a comment
animeshsingh
left a comment
There was a problem hiding this comment.
Have these changed been tested on prior version as well? Also how did values.yaml work before when it was using test namespace, since everything is deployed currently in default?
Contributor
Author
|
I use the latest RBAC API which only available for 1.8 and above, and I tested on both 1.8 and 1.9. I added a new option for users who are using 1.7 or below to disable the RBAC on LCM. Regrading to the namespace in values.yaml, it wasn't used on the helm template before. Thus everything is deployed to default namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Kubernetes 1.9 and above, the default service account is not allow to view and consume cluster resources. Thus, we will assign the default edit role to LCM, so LCM can view and distribute resources to the corresponding learners.
This PR also fixes #21