This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Merged
Conversation
Tomcli
approved these changes
Apr 4, 2018
Contributor
Tomcli
left a comment
Tomcli
left a comment
There was a problem hiding this comment.
LGTM other than a small typo.
CLA.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| To contribute, please submit a Pull Request. As part of tha, please a very simple step, include a line modeled after this line: “DCO 1.1 Signed-off-by: Random J Developer <random@developer.org>" as part of your pull request comments. By doing this one simple thing you are telling the community that you wrote the code you are contributing or have the right to pass on the code that you are contributing. The DCO 1.1 referenced is the Developer Certificate of Origin that is used in the Linux Kernel community, you can find it [here](https://elinux.org/Developer_Certificate_Of_Origin). | |||
Contributor
There was a problem hiding this comment.
There's a typo in As part of "that".
Contributor
|
I think we should add a link in the CONTRIBUTING.md or main README to let people aware of the CLA when committing pull requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.