This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Fix logging bug and clean up on helm chart#53
Merged
animeshsingh merged 2 commits intomasterfrom Apr 6, 2018
Merged
Conversation
animeshsingh
reviewed
Apr 6, 2018
Contributor
animeshsingh
left a comment
animeshsingh
left a comment
There was a problem hiding this comment.
Looks good - except for the new numbers for cpu et all - how did we come up with those?
| logCollectorMemInMB=100 | ||
| logCollectorMilliCPU=60 | ||
| logCollectorMemInMB=300 | ||
| controllerMilliCPU=20 |
Contributor
There was a problem hiding this comment.
How did we come up with these numbers?
Contributor
Author
There was a problem hiding this comment.
Similar to the Load Training Data memory, giving log collector 3x capacity seems to be the right fix. 2x capacity will work on our example but it will be insufficient again with a bigger job. I am working on moving these constants to the helm chart, so in the future users can just customize these number based on their needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCO 1.1 Signed-off-by: Tommy Li tommy.chaoping.li@ibm.com