Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Update FfDL UI dependencies and fix Helm issue#73

Merged
animeshsingh merged 1 commit intoIBM:masterfrom
Tomcli:ui-dependencies
Apr 27, 2018
Merged

Update FfDL UI dependencies and fix Helm issue#73
animeshsingh merged 1 commit intoIBM:masterfrom
Tomcli:ui-dependencies

Conversation

@Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Apr 27, 2018

Some deprecated UI dependencies are vulnerable and failing the Travis Docker build. Thus, update the UI and node dependencies. (Note: package-lock.json is for version control, it doesn't affect the code)

UPDATE:

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Tomcli
Copy link
Contributor Author

Tomcli commented Apr 27, 2018

Looks like the Travis is failing with the latest helm release. Will add a commit to fix it.

@Tomcli Tomcli added the CI/CD label Apr 27, 2018
* Clarify Minikube's develop environment
@Tomcli Tomcli changed the title [WIP] Update FfDL UI dependencies Update FfDL UI dependencies and fix Helm issue Apr 27, 2018
@Tomcli
Copy link
Contributor Author

Tomcli commented Apr 27, 2018

UPDATE: resolved helm issue by enabling automountServiceAccountToken. The latest Helm issue only happens on some Linux environment with minikube.

@Tomcli Tomcli requested a review from animeshsingh April 27, 2018 19:53
@animeshsingh animeshsingh merged commit 283a7cd into IBM:master Apr 27, 2018
@Tomcli Tomcli mentioned this pull request Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants