Conversation
97c9bdb to
497f5ed
Compare
4bac27f to
544d42b
Compare
… before. Might break CI.
3166d45 to
ddb36a6
Compare
etc/examples/tf-model/manifest.yml
Outdated
| container: tf_trained_model | ||
| connection: | ||
| auth_url: http://s3.default.svc.cluster.local | ||
| auth_url: test |
There was a problem hiding this comment.
Do we have to change the auth_url to test? If so, we need to change all the sed commands and examples in our READMEs to make it consistent.
There was a problem hiding this comment.
Tested on my CPU cluster, it is working. Just a few questions regrading to the new changes. Once we resolved that we need to fix the README to match with the new instructions and pass Travis.
I think Travis failed on lack of memory/disk or improper docker version/binary. (need to add some debugging logs to figure out)
| - mountPath: /etc/static-volumes | ||
| name: static-volumes-config-volume | ||
| - mountPath: /etc/static-volumes-v2 | ||
| name: static-volumes-config-volume-v2 |
There was a problem hiding this comment.
Why do we need a new volume configmap?
Makefile
Outdated
| mkdir -p build; test -e dashboard || (git clone $(UI_REPO) build/ffdl-ui; ln -s build/ffdl-ui dashboard) | ||
| (cd dashboard && (if [ "$(VM_TYPE)" = "minikube" ]; then eval $$(minikube docker-env); fi; \ | ||
| docker build -q -t $(DOCKER_REPO)/$(DOCKER_NAMESPACE)/$(IMAGE_NAME_PREFIX)ui:$(IMAGE_TAG) .; \ | ||
| docker build -t $(DOCKER_REPO)/$(DOCKER_NAMESPACE)/$(IMAGE_NAME_PREFIX)ui:$(IMAGE_TAG) .; \ |
There was a problem hiding this comment.
@sboagibm This is the place that causes the docker-build-ui to have segmentation fault on Travis. I'm not sure is it because Travis has bugs on Docker logging or lack of console/shell memory, but quiet the docker build standard output should let you pass the Travis build. (Tested on my own fork)
Developer's Certificate of Origin 1.1