Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Sboag dlaas pull june14#97

Merged
sboagibm merged 41 commits intoIBM:masterfrom
sboagibm:sboag__dlaas_pull_june14
Aug 1, 2018
Merged

Sboag dlaas pull june14#97
sboagibm merged 41 commits intoIBM:masterfrom
sboagibm:sboag__dlaas_pull_june14

Conversation

@sboagibm
Copy link
Contributor

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@sboagibm sboagibm force-pushed the sboag__dlaas_pull_june14 branch from 97c9bdb to 497f5ed Compare June 25, 2018 15:28
@sboagibm sboagibm force-pushed the sboag__dlaas_pull_june14 branch 2 times, most recently from 4bac27f to 544d42b Compare July 20, 2018 15:53
@sboagibm sboagibm force-pushed the sboag__dlaas_pull_june14 branch from 3166d45 to ddb36a6 Compare July 27, 2018 21:21
container: tf_trained_model
connection:
auth_url: http://s3.default.svc.cluster.local
auth_url: test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to change the auth_url to test? If so, we need to change all the sed commands and examples in our READMEs to make it consistent.

@sboagibm sboagibm requested a review from fplk July 31, 2018 17:52
@sboagibm sboagibm changed the title Sboag dlaas pull june14 (DON'T MERGE OR REVIEW YET) Sboag dlaas pull june14 Jul 31, 2018
Copy link
Contributor

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my CPU cluster, it is working. Just a few questions regrading to the new changes. Once we resolved that we need to fix the README to match with the new instructions and pass Travis.

I think Travis failed on lack of memory/disk or improper docker version/binary. (need to add some debugging logs to figure out)

- mountPath: /etc/static-volumes
name: static-volumes-config-volume
- mountPath: /etc/static-volumes-v2
name: static-volumes-config-volume-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a new volume configmap?

Makefile Outdated
mkdir -p build; test -e dashboard || (git clone $(UI_REPO) build/ffdl-ui; ln -s build/ffdl-ui dashboard)
(cd dashboard && (if [ "$(VM_TYPE)" = "minikube" ]; then eval $$(minikube docker-env); fi; \
docker build -q -t $(DOCKER_REPO)/$(DOCKER_NAMESPACE)/$(IMAGE_NAME_PREFIX)ui:$(IMAGE_TAG) .; \
docker build -t $(DOCKER_REPO)/$(DOCKER_NAMESPACE)/$(IMAGE_NAME_PREFIX)ui:$(IMAGE_TAG) .; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sboagibm This is the place that causes the docker-build-ui to have segmentation fault on Travis. I'm not sure is it because Travis has bugs on Docker logging or lack of console/shell memory, but quiet the docker build standard output should let you pass the Travis build. (Tested on my own fork)

Copy link
Contributor

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sboagibm sboagibm merged commit 0f053c1 into IBM:master Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants