Functionality to interface with AISteer360's steering pipelines#12
Merged
dennislwei merged 9 commits intoIBM:mainfrom Jan 20, 2026
Merged
Functionality to interface with AISteer360's steering pipelines#12dennislwei merged 9 commits intoIBM:mainfrom
dennislwei merged 9 commits intoIBM:mainfrom
Conversation
Signed-off-by: Erik Miehling <emiehling@gmail.com>
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
…compatible with PR IBM#11 Signed-off-by: Dennis Wei <dwei@us.ibm.com>
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
dennislwei
reviewed
Jan 8, 2026
| - id: isort | ||
| name: isort (python) | ||
| args: ["--profile", "black", "--filter-files"] | ||
| - repo: https://github.com/ibm/detect-secrets |
Member
There was a problem hiding this comment.
Should this and the following lines be committed or were they only for debugging?
Contributor
Author
There was a problem hiding this comment.
It's intended. We want isort consistent with black and only on tracked files, hence --profile black --filter-files.
dennislwei
reviewed
Jan 8, 2026
| _device (str): | ||
| Device on which the model resides. | ||
| _runtime_kwargs (dict or None): | ||
| Runtime keyword arguments. |
Member
There was a problem hiding this comment.
More informative description for _runtime_kwargs?
dennislwei
reviewed
Jan 8, 2026
| tokenizer (transformers tokenizer): | ||
| Tokenizer corresponding to model. | ||
| runtime_kwargs (dict or None): | ||
| Runtime keyword arguments. |
Member
There was a problem hiding this comment.
More informative description for runtime_kwargs?
Member
|
Thanks @emiehling. I resolved conflicts and added one thing to be compatible with #11. I also completed the docstrings. Could you please take a quick look at my remaining comments (only two minor ones effectively)? I will test this version of ICX360 in the meantime. |
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
Signed-off-by: Erik Miehling <emiehling@gmail.com>
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
Signed-off-by: Dennis Wei <dwei@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.