Conversation
…lso be set after calling AS400.validateSignon() This causes issues when threads are used for communication with the system, as soTimeout and threadsUsed are generally incompatible. Signed-off-by: Parker Young <143426808+pjyoung-ibm@users.noreply.github.com>
nadiramra
approved these changes
Oct 22, 2024
Member
nadiramra
left a comment
nadiramra
left a comment
There was a problem hiding this comment.
I believe this fix is reasonable. I also noticed that we do not copy properties in AS400(AS400 system) constructor. I will change that to also copy the properties instead of sharing SocketProperties object between AS400 objects.
Signed-off-by: John Eberhard <102746950+jeber-ibm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was discovered internally where calling
AS400.setvalidateSignonTimeOut()and then subsequently callingAS400.validateSignon()would cause the SocketProperties on that AS400 object to have thesoTimeoutset for future host server connections. This causes an issue when threads are used for communication, as soTimeout and threadsUsed are generally incompatible. This manifested as "Read time out" errors in code that had a long time between requests to the system. Switching thevalidateSignon()code to copy the socket properties instead of changing the main reference cleared up the issue.