Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Conversation

@AnthonyAmanse
Copy link
Contributor

This fixes persistence issue in GitLab. This commit properly mounts the correct container location in the gitlab container.
Source of documentation: https://docs.gitlab.com/omnibus/docker/#where-is-the-data-stored.

Previously when restarting the gitlab pod, we lose all the repository/project's contents. This commit also persists the GitLab configuration files.

Signed-off-by: AnthonyAmanse ghieamanse@gmail.com

@AnthonyAmanse AnthonyAmanse requested a review from loafyloaf May 10, 2018 23:08
Copy link
Member

@loafyloaf loafyloaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnthonyAmanse hrm - the gitlab pod reports a CreateContainerConfigError...

@AnthonyAmanse
Copy link
Contributor Author

@loafyloaf hmm. I guess subPath: doesn't work well with the hostPath: from local-volumes.yaml. hostPath: isn't really intended to work with multi-node clusters since it doesn't sync data in the paths between multiple nodes. I'll fix the CI in another PR.

Will hold this for now

This fixes persistence issue in GitLab. This commit properly mounts the correct container location in the gitlab container.
Source of documentation: https://docs.gitlab.com/omnibus/docker/#where-is-the-data-stored.

Previously when restarting the gitlab pod, we lose all the repository/project's contents. This commit also persists the GitLab configuration files.

Signed-off-by: AnthonyAmanse <ghieamanse@gmail.com>
Copy link
Member

@loafyloaf loafyloaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnthonyAmanse AnthonyAmanse merged commit 9ccbeee into IBM:master May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants