Always report FIPS mode true on developer platforms#1166
Merged
jasonkatonica merged 1 commit intoIBM:mainfrom Feb 12, 2026
Conversation
Collaborator
Author
|
I was trying to rename the branch to match the PR title, but unfortunately the PR got closed by mistake. This is the newly updated PR. |
Mohit-Rajbhar100698
force-pushed
the
fix/disallow-weak-rsa-keys-for-fips-on-macos-in-developer-mode
branch
from
f3ef91e to
6b75d60
Compare
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
Member
|
Hi Mohit, I think the PR description and title ( and associated commit title and description ) are a bit misleading as the update is much more broad then just impacts to RSA. Perhaps something like this would make sense? |
jasonkatonica
requested changes
Feb 9, 2026
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusFIPS.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusFIPS.java
Outdated
Show resolved
Hide resolved
Mohit-Rajbhar100698
force-pushed
the
fix/disallow-weak-rsa-keys-for-fips-on-macos-in-developer-mode
branch
from
6b75d60 to
557e489
Compare
Mohit-Rajbhar100698
changed the title
Mohit-Rajbhar100698
force-pushed
the
fix/disallow-weak-rsa-keys-for-fips-on-macos-in-developer-mode
branch
from
557e489 to
58368d9
Compare
jasonkatonica
requested changes
Feb 11, 2026
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusFIPS.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
requested changes
Feb 11, 2026
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusFIPS.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusFIPS.java
Outdated
Show resolved
Hide resolved
Mohit-Rajbhar100698
force-pushed
the
fix/disallow-weak-rsa-keys-for-fips-on-macos-in-developer-mode
branch
from
58368d9 to
28f7fd9
Compare
The OpenJCEPlusFIPS provider may run on platforms that support developer mode. On these systems, the provider should always report that it is operating in FIPS mode to ensure behavior is consistent with fully FIPS-certified platforms. This change simulates FIPS operation as closely as possible in development environments. Fixes: https://github.ibm.com/runtimes/jit-crypto/issues/1076 Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
fix/disallow-weak-rsa-keys-for-fips-on-macos-in-developer-mode
branch
from
3a3e062 to
b1e4fa6
Compare
johnpeck-us-ibm
approved these changes
Feb 12, 2026
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenJCEPlusFIPS provider may run on platforms that support developer mode. On these systems, the provider should always report that it is operating in FIPS mode to ensure behavior is consistent with fully FIPS-certified platforms. This change simulates FIPS operation as closely as possible in development environments.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com