fix(ado-core): Enable decorated experiments with ray.remote #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to change the signature of the wrapper.
Member
|
Checks Summary Last run: 2025-11-11T13:13:47.334Z Code Risk Analyzer vulnerability scan found 2 vulnerabilities:
|
srikumar003
approved these changes
Nov 11, 2025
Collaborator
srikumar003
left a comment
srikumar003
left a comment
There was a problem hiding this comment.
I have run this branch against a custom_experiment and verified that the experiment is executed with these changes
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to change the signature of the wrapper.
By default functool.wraps assigns the signature of the wrapped function to the signature metadata of the wrapper, even if the wrapper has different parameters.
ray uses this metadata when it wraps a function (ray.remote) - to determine serialisation etc. Hence if the wrapper changed parameters of the function, it will not work with ray out-of-the-box.