-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(core): split orchestrate into submodules #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring moves general/explore orchestration function to private modules for clarity. However we don't want to expose this private modules external - want to keep the access point orchestrate.py
orchestrate_explore_operation
…operation # Conflicts: # .secrets.baseline # orchestrator/modules/operators/orchestrate.py
Member
Author
|
@AlessandroPomponio Need this merged relatively quickly as it moves code. This means any other PRs needed to modify this code should work using the new locations. |
Member
|
Checks Summary Last run: 2025-11-13T19:56:05.506Z Code Risk Analyzer vulnerability scan found 2 vulnerabilities:
|
AlessandroPomponio
previously approved these changes
Nov 13, 2025
…operation # Conflicts: # orchestrator/modules/operators/orchestrate.py
AlessandroPomponio
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves parts of the orchestrate module into four private modules. It does not change any code.
The aim is to separate concerns in order to enhance maintainability.
It is necessary in order to address #200 effectively (ensure consistent shutdown behaviour including signal handling, actor cleanup etc, with nested operations).
orchestrateremains the main entry point to operation orchestration functions. The private modules are