feat: support auto_stop_method for SFTTrainer experiments #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VassilisVassiliadis
force-pushed
the
vv_add_support_for_auto_stop_method
branch
from
0721735 to
f67ffe6
Compare
|
@danielelotito here's the PR for the auto-stop-method you developed |
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
…ameter Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
VassilisVassiliadis
force-pushed
the
vv_add_support_for_auto_stop_method
branch
from
9e2d071 to
8ead4c8
Compare
...tors/sfttrainer/ado_actuators/sfttrainer/wrapper_fms_hf_tuning/scripts/wrapper_sfttrainer.py
Outdated
Show resolved
Hide resolved
...tors/sfttrainer/ado_actuators/sfttrainer/wrapper_fms_hf_tuning/scripts/wrapper_sfttrainer.py
Show resolved
Hide resolved
plugins/actuators/sfttrainer/ado_actuators/sfttrainer/experiments/common.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
…eriments Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
...tors/sfttrainer/ado_actuators/sfttrainer/wrapper_fms_hf_tuning/scripts/wrapper_sfttrainer.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
…ttrainer.py Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
Signed-off-by: Vassilis Vassiliadis <vassilis.vassiliadis@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method for automatically stopping measurements that divides the training runtime of a measurement into 2 parts:
The method then drops system metrics and training metrics (e.g. throughput) related to the Warmup phase. The final observed properties for measurements that use
auto_stop_method=1will only contain information from the Stable Phase.