fix(schema): ensure experiment_id is string in series representation#703
Merged
AlessandroPomponio merged 6 commits intomainfrom Mar 18, 2026
Merged
fix(schema): ensure experiment_id is string in series representation#703AlessandroPomponio merged 6 commits intomainfrom
AlessandroPomponio merged 6 commits intomainfrom
Conversation
The experiment_id field in ValidMeasurementResult.series_representation and Entity.experiment_series was being set to the ExperimentReference instance. This rendered as the id when outputting as CSV. However, when outputting as json it was the pydantic JSON dump. The field properly should just be the string id c.f. entity "identifier" field. This commit makes this the case.
Member
|
Checks Summary Last run: 2026-03-18T10:32:24.941Z Code Risk Analyzer vulnerability scan found 1 vulnerabilities:
Mend Unified Agent vulnerability scan found 1 vulnerabilities:
|
Member
|
Doesn't |
Member
Author
Sure |
Member
Author
|
Changes made. |
The value should only be a string.
Member
Author
|
@AlessandroPomponio I simplified one change. |
danielelotito
pushed a commit
that referenced
this pull request
Mar 23, 2026
…703) * fix(schema): ensure experiment_id is string The experiment_id field in ValidMeasurementResult.series_representation and Entity.experiment_series was being set to the ExperimentReference instance. This rendered as the id when outputting as CSV. However, when outputting as json it was the pydantic JSON dump. The field properly should just be the string id c.f. entity "identifier" field. This commit makes this the case. * chore(schema): using str instead of format string * test(schema): update tests * fix(operators): update as experiment_id no longer a references * test(schema): further updates as experiment_id no longer an object. * chore(operators): simplification The value should only be a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experiment_id field in ValidMeasurementResult.series_representation and Entity.experiment_series was being set to the ExperimentReference instance.
This rendered as the id when outputting as CSV. However, when outputting as json it was the pydantic JSON dump.
The field properly should just be the string id c.f. entity "identifier" field. This commit makes this the case.