refactor(core): remove unused CoreResourceKinds#767
Merged
Conversation
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Member
michael-johnston
left a comment
There was a problem hiding this comment.
There is an import change that looks unnecessary
michael-johnston
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes unused resource kinds from the orchestrator core module. Specifically, it removes the
RESOURCE,RESULT, andOPERATORresource kinds from theCoreResourceKindsenum and cleans up related references throughout the codebase. Additionally, it makes thekindfield inADOResourcea required field by removing its default value.Closes #251
Files Changed
📄
orchestrator/cli/utils/resources/mappings.pyRemoves the
OPERATORresource kind from theresource_kinds_to_humanmapping dictionary, which was used to provide human-readable names for resource types.📄
orchestrator/core/__init__.pyRemoves the
RESOURCEresource kind mapping from thekindmapdictionary. Also adds explicit type annotation (as ADOResource) to theADOResourceimport for better type clarity.📄
orchestrator/core/resources.pyRemoves three unused resource kinds from the
CoreResourceKindsenum:RESOURCE,RESULT, andOPERATOR. Additionally, removes the default value ofCoreResourceKinds.RESOURCEfrom thekindfield in theADOResourceclass, making it a required field instead of optional.