Skip to content

refactor(core): remove unused CoreResourceKinds#767

Merged
michael-johnston merged 2 commits into
mainfrom
ap_251_clean_up_core_resource_kinds
Mar 31, 2026
Merged

refactor(core): remove unused CoreResourceKinds#767
michael-johnston merged 2 commits into
mainfrom
ap_251_clean_up_core_resource_kinds

Conversation

@AlessandroPomponio
Copy link
Copy Markdown
Member

@AlessandroPomponio AlessandroPomponio commented Mar 31, 2026

Summary

This pull request removes unused resource kinds from the orchestrator core module. Specifically, it removes the RESOURCE, RESULT, and OPERATOR resource kinds from the CoreResourceKinds enum and cleans up related references throughout the codebase. Additionally, it makes the kind field in ADOResource a required field by removing its default value.

Closes #251

Files Changed

📄 orchestrator/cli/utils/resources/mappings.py

Removes the OPERATOR resource kind from the resource_kinds_to_human mapping dictionary, which was used to provide human-readable names for resource types.

📄 orchestrator/core/__init__.py

Removes the RESOURCE resource kind mapping from the kindmap dictionary. Also adds explicit type annotation (as ADOResource) to the ADOResource import for better type clarity.

📄 orchestrator/core/resources.py

Removes three unused resource kinds from the CoreResourceKinds enum: RESOURCE, RESULT, and OPERATOR. Additionally, removes the default value of CoreResourceKinds.RESOURCE from the kind field in the ADOResource class, making it a required field instead of optional.

Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
Comment thread orchestrator/core/__init__.py
Copy link
Copy Markdown
Member

@michael-johnston michael-johnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an import change that looks unnecessary

@michael-johnston michael-johnston self-requested a review March 31, 2026 14:11
@michael-johnston michael-johnston added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 55f209e Mar 31, 2026
19 checks passed
@michael-johnston michael-johnston deleted the ap_251_clean_up_core_resource_kinds branch March 31, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: clean up CoreResourceKinds

2 participants